gh-155053: Fix GenericAlias crash on OOM - #155055
Open
BHUVANSH855 wants to merge 5 commits into
Open
Conversation
picnixz
requested changes
Aug 2, 2026
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Contributor
Author
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @picnixz: please review the changes made to this pull request. |
picnixz
reviewed
Aug 2, 2026
picnixz
reviewed
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a NULL dereference in
Objects/genericaliasobject.cwhentuple_extend()fails during
TypeVarTuplesubstitution under allocation failure.When
_PyTuple_Resize()fails, it clears its out-parameter, sosubargsbecomes
NULL. The error path insubs_tvars()must not callPy_DECREF(subargs)and should instead propagate theMemoryError.Also add a regression test covering the allocation-failure path using
_testcapi.set_nomemory()to ensure aMemoryErroris raised instead ofcrashing the interpreter.
Issue: gh-155053